Re: [Qemu-ppc] system-ppcemb -M bamboo, troubles with RTC

[Stefan Weil]

Am 01.07.2013 11:22, schrieb Alexander Graf:
> Hi Nello,
>
> On 01.07.2013, at 03:29, nello martuscielli wrote:
>
>> On Sun, Jun 30, 2013 at 2:26 PM, Alexander Graf <address@hidden> wrote:
>>> Hi Nello,
>>>
>>> On 30.06.2013, at 12:01, nello martuscielli wrote:
>>>
>>> hi, i'm giving a try to have a working qemu-system-ppcemb -M bamboo but 
>>> i've some troubles how to set RTC . I'm using qemu-1.5.1 on a real PowerPC 
>>> 32bit machine (iBook G4).
>>>
>>>
>>> Phew. That must be terribly slow. I'd certainly recommend a recent x86 
>>> machine as the host if you want to actually work with your guest. Running 
>>> on a PPC host in TCG mode (emulation) doesn't really buy you anything.
>>>
>> hallo Alexander,
>>
>> indeed it's quite slow. I hoped to use TCG and/or KVM but if i try to
>> build qemu-1.5.1 with --enable-tcg-interpreter i get:
> The TCG interpreter is an even slower variant of TCG :). You really don't 
> want that on a G4.
>
>> [...]
>> CC    hw/virtio/dataplane/vring.o
>>  GEN   ppc-softmmu/hmp-commands.h
>>  GEN   ppc-softmmu/qmp-commands-old.h
>>  GEN   ppc-softmmu/config-target.h
>>  CC    ppc-softmmu/exec.o
>>  CC    ppc-softmmu/translate-all.o
>>  CC    ppc-softmmu/cpu-exec.o
>>  CC    ppc-softmmu/tcg/tcg.o
>> In file included from 
>> /home/ports/Qemu/qemu/work/src/qemu-1.5.1/tcg/tcg.h:49:0,
>>                 from 
>> /home/ports/Qemu/qemu/work/src/qemu-1.5.1/tcg/tcg-op.h:24,
>>                 from /home/ports/Qemu/qemu/work/src/qemu-1.5.1/tcg/tcg.c:50:
>> /home/ports/Qemu/qemu/work/src/qemu-1.5.1/tcg/tci/tcg-target.h:174:20:
>> error: redefinition of 'flush_icache_range'
>> /home/ports/Qemu/qemu/work/src/qemu-1.5.1/include/qemu/cache-utils.h:18:20:
>> note: previous definition of 'flush_icache_range' was here
>> make[1]: *** [tcg/tcg.o] Error 1
>> make: *** [subdir-ppc-softmmu] Error 2
> However, it should compile. CC'ing Stefan.

Hi Alex,

include/qemu/cache-utils.h could be modified to use

#if defined(_ARCH_PPC) && !defined(CONFIG_TCG_INTERPRETER)

Maybe this modification is sufficient.

Is there still a reason why PPC declares this inline function in
cache-utils instead of tcg/ppc/tcg-target.h?

All other tcg targets use tcg-target.h. They also use tcg_target_ulong
in the function prototype of flush_icache_range.

I stopped cross compiling for PPC because it is too difficult to
provide all dependencies (glib2, ...) in my Debian environment,
so I have currently no chance of sending a tested patch :-(

Regards
Stefan