[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH v3 5/6] bitops: add BITNR macro
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-ppc] [PATCH v3 5/6] bitops: add BITNR macro |
|
Date: |
Thu, 14 Nov 2013 09:54:52 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130923 Thunderbird/17.0.9 |
Il 14/11/2013 06:51, Alexey Kardashevskiy ha scritto:
>> > The wrappers are not usable where you have constant expressions as in
>> > your case. So your original patch is good IMO, except for the __ at the
>> > beginning of __BITNR.
>
> There are 2 macros, one (BITNR) uses the other (__BITNR). What would the
> good name be for BITNR then?
I don't know, perhaps BITNR and BITNR_?
Names starting with __ or _+uppercase are reserved by the C standard.
Paolo
[Qemu-ppc] [PATCH v3 3/6] target-ppc: add "compat" CPU option, Alexey Kardashevskiy, 2013/11/11
[Qemu-ppc] [PATCH v3 5/6] bitops: add BITNR macro, Alexey Kardashevskiy, 2013/11/11
[Qemu-ppc] [PATCH v3 2/6] target-ppc: make use of new -cpu suboptions handling, Alexey Kardashevskiy, 2013/11/11
[Qemu-ppc] [PATCH v3 6/6] target-ppc: demonstrate new "vsx" property, Alexey Kardashevskiy, 2013/11/11