[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH v4] ppc: introduce CPUPPCState::cpu_dt_id and CPUS
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-ppc] [PATCH v4] ppc: introduce CPUPPCState::cpu_dt_id and CPUState::kvm_cpu_id |
|
Date: |
Mon, 18 Nov 2013 09:34:42 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130923 Thunderbird/17.0.9 |
Il 18/11/2013 04:02, Alexey Kardashevskiy ha scritto:
> On 11/15/2013 09:40 PM, Paolo Bonzini wrote:
>> Il 15/11/2013 06:14, Alexey Kardashevskiy ha scritto:
>>>
>>> It does not feel that we really need CPUState::kvm_cpu_id and
>>> direct calling of kvm_arch_vcpu_id() would be enough.
>>
>> Indeed -- and it should be kvm_ppc_vcpu_id() since other architectures
>> do not need it.
>
> And ignore kvm_arch_vcpu_id() for spapr/ppc?
Sorry, brain fart - i meant ppc_get_vcpu_dt_id but it has already been
objected to earlier. So the patch is ok for me, modulo removal of
kvm_cpu_id which you already proposed above.
Paolo