[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH v2 1/4] target-ppc: Extend rtas-blob
From: |
Alexander Graf |
Subject: |
Re: [Qemu-ppc] [PATCH v2 1/4] target-ppc: Extend rtas-blob |
Date: |
Fri, 05 Sep 2014 09:42:20 +0200 |
User-agent: |
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.1.0 |
On 04.09.14 13:13, Aravinda Prasad wrote:
> Extend rtas-blob to accommodate error log. Error log
> structure is saved in rtas space upon a machine check
> exception.
>
> Signed-off-by: Aravinda Prasad <address@hidden>
> ---
> hw/ppc/spapr.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index 4b20e36..4a7c0ae 100644
> --- a/hw/ppc/spapr.c
> +++ b/hw/ppc/spapr.c
> @@ -1409,6 +1409,10 @@ static void ppc_spapr_init(MachineState *machine)
>
> filename = qemu_find_file(QEMU_FILE_TYPE_BIOS, "spapr-rtas.bin");
> spapr->rtas_size = get_image_size(filename);
> +
> + /* Resize blob to accommodate error log at a page aligned address */
> + spapr->rtas_size = TARGET_PAGE_ALIGN(spapr->rtas_size) +
> TARGET_PAGE_SIZE;
I think it's clearer if you do
#define RTAS_ERROR_LOG_SIZE 4096
and add this to the aligned size instead.
Alex