[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PATCH 0/4] macio: change DMA methods over t
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PATCH 0/4] macio: change DMA methods over to offset/len implementation |
Date: |
Tue, 2 Jun 2015 03:28:04 -0400 (EDT) |
----- Original Message -----
> From: "Mark Cave-Ayland" <address@hidden>
> To: "John Snow" <address@hidden>, address@hidden, address@hidden,
> address@hidden
> Sent: Tuesday, June 2, 2015 1:18:42 AM
> Subject: Re: [Qemu-devel] [PATCH 0/4] macio: change DMA methods over to
> offset/len implementation
>
> On 02/06/15 00:09, John Snow wrote:
>
> > On 05/31/2015 04:05 PM, Mark Cave-Ayland wrote:
> >> This patchset follows on from my recent work on fixing issues with the
> >> macio controller, and remodels the new pmac_dma_read() and
> >> pmac_dma_write()
> >> functions in a similar manner to the unaligned block functions.
> >>
> >> With this in place, long chains of overlapping unaligned requests as used
> >> by OS X/Darwin will now work correctly without introducting torn sector
> >> errors when writing to disk.
> >>
> >> Also included are some tidy-ups as a result of the above changes.
> >>
> >> Signed-off-by: Mark Cave-Ayland <address@hidden>
> >>
> >> Mark Cave-Ayland (4):
> >> macio: switch pmac_dma_read() over to new offset/len implementation
> >> macio: switch pmac_dma_write() over to new offset/len implementation
> >> macio: update comment/constants to reflect the new code
> >> macio: remove remainder_len DBDMA_io property
> >>
> >> hw/ide/macio.c | 271
> >> +++++++++++++++++---------------------------
> >> include/hw/ppc/mac_dbdma.h | 4 +-
> >> 2 files changed, 105 insertions(+), 170 deletions(-)
> >>
> >
> > More 32/64bit printf string problems:
> >
> > macio.c:81: sector_num is int64_t (PRId64)
> > macio.c:93: sector_num
> > head_bytes is size_t (%zu)
> > macio.c:107: sector_num
> > tail_bytes is size_t (%zu)
> > macio.c:147: sector_num
> > macio.c:160: sector_num
> > macio.c:178: sector_num
>
> Ah oops. Do you need me to correct? And do you have a quick way of
> testing a 32-bit build on a 64-bit OS? (-m32)?
You can create an LXC container with 32bit binaries on a 64bit kernel.
Something like "sudo lxc-create -t debian -n debian32 -- -a i686"
or "sudo lxc-create -t fedora -n fedora32 -- -a i686"
Available templates are: /usr/share/lxc/templates (remove the "lxc-")
Laurent