[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PATCH for-2.5 2/3] spapr_drc: Change value
From: |
Eric Blake |
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PATCH for-2.5 2/3] spapr_drc: Change value of property "fdt" from null back to {} |
Date: |
Thu, 3 Dec 2015 10:30:38 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 12/03/2015 10:13 AM, Markus Armbruster wrote:
> Eric Blake <address@hidden> writes:
>
>> On 12/03/2015 09:37 AM, Markus Armbruster wrote:
>>> prop_get_fdt() misuses the visitor API: when fdt is null, it doesn't
>>> visit anything. object_property_get_qobject() happily
>>> object_property_get_qobject(). Amazingly, the latter survives the
>>
>> Something got lost or otherwise corrupted in that sentence. Were you
>> trying to say one function happily calls another? If so, which of the
>> two "object_property_get_qobject()" strings should be changed, to what?
>
> No idea what happened. Correction: insert "calls" after "happily":
>
> prop_get_fdt() misuses the visitor API: when fdt is null, it doesn't
> visit anything. object_property_get_qobject() happily calls
> object_property_get_qobject().
That still reads "A() happily calls A()" - are we talking about
recursion here? I still wonder if you meant a second function name,
and/or mention of the fact that we are calling a function with NULL
rather than a QObject?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
Re: [Qemu-ppc] [PATCH for-2.5 2/3] spapr_drc: Change value of property "fdt" from null back to {}, David Gibson, 2015/12/03
[Qemu-ppc] [PATCH for-2.5 1/3] spapr_drc: Handle visitor errors properly, Markus Armbruster, 2015/12/03
[Qemu-ppc] [PATCH for-2.5 3/3] spapr_drc: Make device "spapr-dr-connector" unavailable with -device, Markus Armbruster, 2015/12/03