[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PULL 00/66] ppc-for-2.8 queue 20160906
From: |
Benjamin Herrenschmidt |
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PULL 00/66] ppc-for-2.8 queue 20160906 |
Date: |
Wed, 07 Sep 2016 12:26:53 +1000 |
On Wed, 2016-09-07 at 07:52 +1000, Benjamin Herrenschmidt wrote:
> On Tue, 2016-09-06 at 23:09 +0200, Thomas Huth wrote:
> >
> > The bad commit is: "ppc: Speed up load/store multiple"
> >
> > There are two "#if defined(HOST_WORDS_BIGENDIAN)" sections in this
> > patch
> > which are both bad: The memcpy tries to copy 32-bit values into 64-
> > bit
> > registers, which of course does not work (unless you compile this
> > code
> > for a 32-bit host only where the size of a gpr is only 32-bit).
>
> The instruction does that. It only copies 32-bits. I think it's
> correct.
Except of course when the host is 64-bit and we enable with a 64-bit
target_ulong ... ugh ;-)
Drop the patch for now, I'll redo it later.
Cheers,
Ben.
- [Qemu-ppc] [PULL 54/66] ppc: Rename #include'd .c files to .inc.c, (continued)
- [Qemu-ppc] [PULL 54/66] ppc: Rename #include'd .c files to .inc.c, David Gibson, 2016/09/05
- [Qemu-ppc] [PULL 59/66] ppc: Stop dumping state on all exceptions in linux-user, David Gibson, 2016/09/05
- [Qemu-ppc] [PULL 17/66] ppc: Move classic fp ops out of translate.c, David Gibson, 2016/09/05
- [Qemu-ppc] [PULL 22/66] ppc: Rename fload_invalid_op_excp to float_invalid_op_excp, David Gibson, 2016/09/05
- [Qemu-ppc] [PULL 20/66] ppc: Move VMX ops out of translate.c, David Gibson, 2016/09/05
- [Qemu-ppc] [PULL 18/66] ppc: Move embedded spe ops out of translate.c, David Gibson, 2016/09/05
- Re: [Qemu-ppc] [Qemu-devel] [PULL 00/66] ppc-for-2.8 queue 20160906, no-reply, 2016/09/06
- Re: [Qemu-ppc] [Qemu-devel] [PULL 00/66] ppc-for-2.8 queue 20160906, Peter Maydell, 2016/09/06
- Re: [Qemu-ppc] [Qemu-devel] [PULL 00/66] ppc-for-2.8 queue 20160906, Thomas Huth, 2016/09/06
[Qemu-ppc] [PULL 00/66] ppc-for-2.8 queue 20160906, David Gibson, 2016/09/05