[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH 12/21] ppc/pnv: populate device tree for RTC devic
From: |
David Gibson |
Subject: |
Re: [Qemu-ppc] [PATCH 12/21] ppc/pnv: populate device tree for RTC devices |
Date: |
Mon, 10 Apr 2017 15:18:57 +1000 |
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Wed, Apr 05, 2017 at 02:41:37PM +0200, Cédric Le Goater wrote:
> The code could be common to any ISA device but we are missing the IO
> length.
>
> Signed-off-by: Cédric Le Goater <address@hidden>
Reviewed-by: David Gibson <address@hidden>
> ---
> hw/ppc/pnv.c | 30 ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c
> index a3c8f6594d10..2f9c41e350d4 100644
> --- a/hw/ppc/pnv.c
> +++ b/hw/ppc/pnv.c
> @@ -281,6 +281,26 @@ static void powernv_populate_chip(PnvChip *chip, void
> *fdt)
> g_free(typename);
> }
>
> +static void powernv_populate_rtc(ISADevice *d, void *fdt, int lpc_off)
> +{
> + uint32_t io_base = d->ioport_id;
> + uint32_t io_regs[] = {
> + cpu_to_be32(1),
> + cpu_to_be32(io_base),
> + cpu_to_be32(2)
> + };
> + char *name;
> + int node;
> +
> + name = g_strdup_printf("address@hidden", qdev_fw_name(DEVICE(d)),
> io_base);
> + node = fdt_add_subnode(fdt, lpc_off, name);
> + _FDT(node);
> + g_free(name);
> +
> + _FDT((fdt_setprop(fdt, node, "reg", io_regs, sizeof(io_regs))));
> + _FDT((fdt_setprop_string(fdt, node, "compatible", "pnpPNP,b00")));
> +}
> +
> typedef struct ForeachPopulateArgs {
> void *fdt;
> int offset;
> @@ -288,6 +308,16 @@ typedef struct ForeachPopulateArgs {
>
> static int powernv_populate_isa_device(DeviceState *dev, void *opaque)
> {
> + ForeachPopulateArgs *args = opaque;
> + ISADevice *d = ISA_DEVICE(dev);
> +
> + if (object_dynamic_cast(OBJECT(dev), TYPE_MC146818_RTC)) {
> + powernv_populate_rtc(d, args->fdt, args->offset);
> + } else {
> + error_report("unknown isa device address@hidden", qdev_fw_name(dev),
> + d->ioport_id);
> + }
> +
> return 0;
> }
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- [Qemu-ppc] [PATCH 09/21] ipmi: introduce an ipmi_bmc_gen_event() API, (continued)
- [Qemu-ppc] [PATCH 09/21] ipmi: introduce an ipmi_bmc_gen_event() API, Cédric Le Goater, 2017/04/05
- [Qemu-ppc] [PATCH 10/21] ipmi: add SET_SENSOR_READING command, Cédric Le Goater, 2017/04/05
- [Qemu-ppc] [PATCH 11/21] ppc/pnv: scan ISA bus to populate device tree, Cédric Le Goater, 2017/04/05
- [Qemu-ppc] [PATCH 12/21] ppc/pnv: populate device tree for RTC devices, Cédric Le Goater, 2017/04/05
- Re: [Qemu-ppc] [PATCH 12/21] ppc/pnv: populate device tree for RTC devices,
David Gibson <=
- [Qemu-ppc] [PATCH 13/21] ppc/pnv: populate device tree for serial devices, Cédric Le Goater, 2017/04/05
- [Qemu-ppc] [PATCH 14/21] ppc/pnv: populate device tree for IPMI BT devices, Cédric Le Goater, 2017/04/05
- [Qemu-ppc] [PATCH 15/21] ppc/pnv: add initial IPMI sensors for the BMC simulator, Cédric Le Goater, 2017/04/05
- [Qemu-ppc] [PATCH 16/21] ppc/pnv: generate an OEM SEL event on shutdown, Cédric Le Goater, 2017/04/05
- [Qemu-ppc] [PATCH 17/21] qdev: Add a hook for a bus to device if it can add devices, Cédric Le Goater, 2017/04/05