Re: [Qemu-ppc] [PATCH v4 1/6] xics: introduce macros for ICP/ICS link properties

[Cédric Le Goater]

>>> FWIW, other people do that as well (see hw/i386/pc_q35.c for example).  
>>
>> well, I don't see the benefits of changing a string constant by a 
>> define. 
>>
> 
> Improved semantics,  especially since the "xics" string appears in 
> many places with different meanings. 

ah ? If so, we should do a cleanup up. The code seems consistent from 
what I can see. xics is a general name for :

        'PowerPC interrupt controller (type 2)' 

and it is mostly used as a prefix. There are no "xics" object, only a 
XICSFabric which is a QOM interface of the machine with a bunch of 
handlers. It worked out pretty well for sPAPR and PowerNV.

It won't be the case for XIVE, the interrupt controller (type 3) for 
the P9. It is more complex and there are quite a lot of internal 
states which will need to be gathered under an object. We can keep 
the ICPState fortunately but the sources are quite different.

C.