qemu-ppc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PATCH qemu v9 2/2] memory/iommu: introduce IOMMUMemoryRe


From: David Gibson
Subject: Re: [Qemu-ppc] [PATCH qemu v9 2/2] memory/iommu: introduce IOMMUMemoryRegionClass
Date: Sun, 16 Jul 2017 16:45:42 +1000
User-agent: Mutt/1.8.3 (2017-05-23)

On Tue, Jul 11, 2017 at 01:56:20PM +1000, Alexey Kardashevskiy wrote:
> This finishes QOM'fication of IOMMUMemoryRegion by introducing
> a IOMMUMemoryRegionClass. This also provides a fastpath analog for
> IOMMU_MEMORY_REGION_GET_CLASS().
> 
> This makes IOMMUMemoryRegion an abstract class.
> 
> Signed-off-by: Alexey Kardashevskiy <address@hidden>

Reviewed-by: David Gibson <address@hidden>

with the exception of one miniscule nit:

[snip]
> +/**
> + * memory_region_get_iommu_class_nocheck: returns iommu memory region class
> + *   if an iommu or NULL if not
> + *
> + * Returns pointer to IOMMUMemoryRegioniClass if a memory region is an iommu,

Typo                                      ^

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]