[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [RFC PATCH 07/26] ppc/xive: add MMIO handlers to the XIVE
|
From: |
Benjamin Herrenschmidt |
|
Subject: |
Re: [Qemu-ppc] [RFC PATCH 07/26] ppc/xive: add MMIO handlers to the XIVE interrupt source |
|
Date: |
Mon, 24 Jul 2017 18:56:29 +1000 |
On Mon, 2017-07-24 at 14:29 +1000, David Gibson wrote:
> > + case XIVE_ESB_SET_PQ_00:
> > + case XIVE_ESB_SET_PQ_01:
> > + case XIVE_ESB_SET_PQ_10:
> > + case XIVE_ESB_SET_PQ_11:
> > + ret = xive_pq_get(x, lisn);
> > + xive_pq_set(x, lisn, (offset >> 8) & 0x3);
>
> Again I'd prefer xive_pq_set() return the old value itself, for more
> obvious atomicity.
Agreed. That will also help with StoreEOI (store to 0x400 of the EOI
page) which does an EOI then re-sends an interrupt if the old value was
11 (while the load EOI doesn't resend).
Cheers,
Ben.
- Re: [Qemu-ppc] [RFC PATCH 05/26] ppc/xive: define XIVE internal tables, (continued)
[Qemu-ppc] [RFC PATCH 06/26] ppc/xive: introduce a XIVE interrupt source model, Cédric Le Goater, 2017/07/05
Re: [Qemu-ppc] [RFC PATCH 06/26] ppc/xive: introduce a XIVE interrupt source model, Cédric Le Goater, 2017/07/24
[Qemu-ppc] [RFC PATCH 07/26] ppc/xive: add MMIO handlers to the XIVE interrupt source, Cédric Le Goater, 2017/07/05
Re: [Qemu-ppc] [Qemu-devel] [RFC PATCH 07/26] ppc/xive: add MMIO handlers to the XIVE interrupt source, Alexey Kardashevskiy, 2017/07/24
[Qemu-ppc] [RFC PATCH 08/26] ppc/xive: add flags to the XIVE interrupt source, Cédric Le Goater, 2017/07/05