|
From: | Alexey Kardashevskiy |
Subject: | Re: [Qemu-ppc] [RFC PATCH 04/26] ppc/xive: introduce a skeleton for the XIVE interrupt controller model |
Date: | Tue, 25 Jul 2017 11:26:13 +1000 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 24/07/17 23:00, Cédric Le Goater wrote: >>> +#include "qemu/osdep.h" >>> +#include "qemu/log.h" >>> +#include "qapi/error.h" >>> +#include "target/ppc/cpu.h" >>> +#include "sysemu/cpus.h" >>> +#include "sysemu/dma.h" >>> +#include "monitor/monitor.h" >>> +#include "hw/ppc/xive.h" >>> + >>> +#include "xive-internal.h" >>> + >>> +/* >>> + * Main XIVE object >> >> As with XICs, does it really make sense for there to be a "main" XIVE >> object, or should be an interface attached to the machine? > > yes. There are internal tables which are very specific to the controller > and I don't think they belong to the machine. These tables belong to a CPU chip (die?) and we do not emulate these now (machines and cores are the closest) and since we do not want (do we?) to treat a core as a chip, the machine is the most obvious owner for these tables. -- Alexey
[Prev in Thread] | Current Thread | [Next in Thread] |