[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH v2 1/1] PPC: KVM: Support machine option to set VS
From: |
David Gibson |
Subject: |
Re: [Qemu-ppc] [PATCH v2 1/1] PPC: KVM: Support machine option to set VSMT mode |
Date: |
Tue, 15 Aug 2017 21:38:58 +1000 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Tue, Aug 15, 2017 at 02:28:13PM +1000, Sam Bobroff wrote:
> On Mon, Aug 14, 2017 at 05:52:09PM +0200, Greg Kurz wrote:
> > Hi Sam,
> >
> > It seems you forgot to Cc: qemu-devel, which is mandatory for patches to be
> > merged in the master branch.
>
> Oh, sorry! I knew that. Fixed.
[snip]
> > > + }
> > > +}
> > > +
> > > +static void spapr_set_vsmt_mode(sPAPRMachineState *spapr)
> > > +{
> > > + bool vsmt_user = !!spapr->vsmt;
> > > + int kvm_smt = kvmppc_smt_threads();
> > > + int ret;
> > > + const char *machine_name;
> > > +
> > > + machine_name =
> > > object_class_get_name(OBJECT_CLASS(SPAPR_MACHINE_GET_CLASS(spapr)));
> >
> > This makes ./script/checkpatch.pl unhappy:
> >
> > WARNING: line over 80 characters
> > #79: FILE: hw/ppc/spapr.c:2174:
> >
> > Personally, I'd use a intermediate 'smc' variable for
> > SPAPR_MACHINE_GET_CLASS(spapr).
>
> Sure, will do.
>
> > This being said, do we really need to output the versioned machine type ?
> > Or even to output the machine type at all ?
>
> No, we don't have to. I wanted to change the previous message, which
> just said "on PPC" because it actually doesn't apply to all PPC
> machines, only the SPAPR ones. So I thought the message was misleading.
> What do you think?
You can just say "on pseries". This is pseries specific code, so you
don't need to look up the name.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature