[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-trivial] [Qemu-devel] [PATCH] dma/i82374: avoid dou
From: |
Eduardo Otubo |
Subject: |
Re: [Qemu-ppc] [Qemu-trivial] [Qemu-devel] [PATCH] dma/i82374: avoid double creation of i82374 device |
Date: |
Fri, 8 Sep 2017 09:57:05 +0200 |
User-agent: |
Mutt/1.8.3+47 (5f034395e53d) (2017-05-23) |
On Thu, Sep 07, 2017 at 06:05:37PM +0200, Paolo Bonzini wrote:
> Il 02 set 2017 11:17 AM, "Aurelien Jarno" <address@hidden> ha scritto:
>
> On 2017-09-01 11:30, Eduardo Habkost wrote:
> > i82374 is compiled in only on ppc and sh4, so I'm CCing the
> > maintainers for those architectures.
>
> The i82374 device is not useful nor usable on SH4. It has just been
> added in commit 85d3846a39 to be able to run the tests.
>
>
> But that means that the patch is wrong and probably was not tested with
> "make check".
>
> Eduardo's proposal is the right one.
>
Great, I'll just add the missing details and resend the v2. Thanks for
the review.
Regards,
--
Eduardo Otubo
Senior Software Engineer @ RedHat