[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PATCH v2] hw/ide: Emulate SiI3112 SATA cont
From: |
John Snow |
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PATCH v2] hw/ide: Emulate SiI3112 SATA controller |
Date: |
Tue, 19 Dec 2017 20:26:42 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 12/18/2017 08:18 PM, David Gibson wrote:
> On Mon, Dec 18, 2017 at 01:33:07PM -0500, John Snow wrote:
>>
>>
>> On 12/18/2017 07:30 AM, BALATON Zoltan wrote:
>>> On Mon, 18 Dec 2017, David Gibson wrote:
>>>> On Sat, Dec 16, 2017 at 11:42:39PM +0100, BALATON Zoltan wrote:
>>>>> This is a common generic PCI SATA controller that is also used in PCs
>>>>> but more importantly guests running on the Sam460ex board prefer this
>>>>> card and have a driver for it (unlike for other SATA controllers
>>>>> already emulated).
>>>>>
>>>>> Signed-off-by: BALATON Zoltan <address@hidden>
>>>>
>>>> I don't know enough about IDE to give this any more than a quick check
>>>> for anything obviously bogus looking. So,
>>>>
>>>> Reviewed-by: David Gibson <address@hidden>
>>>>
>>>> John, can you take this through your tree, or should I take it through
>>>> the ppc tree?
>>>
>>> I think he said before it can go via ppc tree:
>>>
>>> http://lists.nongnu.org/archive/html/qemu-devel/2017-08/msg04480.html
>>>
>>
>> Yep, I tend to use Acked-by to indicate that it's okay for you to stage.
>> I'll give it another look-over in a minute, but I'm fine with adding the
>> model in general, even if it's not quite complete just yet.
>>
>> (More musings: we really ought to have a way to indicate to QEMU
>> programmatically which devices we think are supported, which are
>> experimental, and which are rudimentary.)
>
> Ok, I've taken it into my tree.
>
Great, thanks :)
Re: [Qemu-ppc] [Qemu-devel] [PATCH v2] hw/ide: Emulate SiI3112 SATA controller, John Snow, 2017/12/20