Re: [Qemu-ppc] [Qemu-devel] [PATCH v2] hw/char: remove legacy interface escc_init()

[Mark Cave-Ayland]

On 19/01/18 13:28, Laurent Vivier wrote:

> Move necessary stuff in escc.h and update type names.
> Remove slavio_serial_ms_kbd_init().
> Fix code style problems reported by checkpatch.pl
> Update mac_newworld, mac_oldworld and sun4m to use directly the
> QDEV interface.
>
> Signed-off-by: Laurent Vivier <address@hidden>
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> v2: in sun4m, move comments about Slavio TTY close to
>      their qdev_prop_set_chr()

Ah okay perhaps I didn't express myself particularly well: what I was 
suggesting was moving the comment above both qdev_create()s rather than 
in the middle e.g.

  /* Slavio TTYA (base+4, Linux ttyS0) is the first QEMU serial device
     Slavio TTYB (base+0, Linux ttyS1) is the second QEMU serial device
   */
   dev = qdev_create(NULL, TYPE_ESCC);
   qdev_prop_set_uint32(dev, "disabled", !machine->enable_graphics);
   ...
   ...
   sysbus_mmio_map(s, 0, hwdef->ms_kb_base);

   dev = qdev_create(NULL, TYPE_ESCC);
   qdev_prop_set_uint32(dev, "disabled", 0);
   ...
   ...
   sysbus_mmio_map(s, 0, hwdef->serial_base);


instead of v1 which does:


   dev = qdev_create(NULL, TYPE_ESCC);
   qdev_prop_set_uint32(dev, "disabled", !machine->enable_graphics);
   ...
   ...
   sysbus_mmio_map(s, 0, hwdef->ms_kb_base);

  /* Slavio TTYA (base+4, Linux ttyS0) is the first QEMU serial device
     Slavio TTYB (base+0, Linux ttyS1) is the second QEMU serial device
   */
   dev = qdev_create(NULL, TYPE_ESCC);
   qdev_prop_set_uint32(dev, "disabled", 0);
   ...   ...
   sysbus_mmio_map(s, 0, hwdef->serial_base);



ATB,

Mark.