Re: [Qemu-ppc] Patch:add 7477a_v1.5

[BALATON Zoltan]

On Sun, 21 Jan 2018, Jd Lyons wrote:
> > On Jan 21, 2018, at 4:25 AM, Mark Cave-Ayland <address@hidden> wrote:
> > On 20/01/18 14:06, James Lyons wrote:
> > > Hope this is ok, not sure the  way to submit a patch for review:
> > > This patch needs a corresponding patch to openbios, that I will submit to the 
> > > openbios list soon.
> > > diff --git a/target/ppc/cpu-models.c b/target/ppc/cpu-models.c
> > > index 6c9bfde..a77469d 100644
> > > --- a/target/ppc/cpu-models.c
> > > +++ b/target/ppc/cpu-models.c
> > > @@ -739,6 +739,8 @@
> > >                  "PowerPC 7447A v1.2 (G4)")
> > >      POWERPC_DEF("7457a_v1.2", CPU_POWERPC_74x7A_v12,              7455,
> > >                  "PowerPC 7457A v1.2 (G4)")
> > > +    POWERPC_DEF("7457a_v1.5", CPU_POWERPC_74x7A_v15,              7455,
> > > +                "PowerPC 7457A v1.5 (G4)")
> > >      /* 64 bits PowerPC                                                       */
> > >  #if defined (TARGET_PPC64)
> > >      POWERPC_DEF("power5+_v2.1", CPU_POWERPC_POWER5P_v21, POWER5P,
> > > diff --git a/target/ppc/cpu-models.h b/target/ppc/cpu-models.h
> > > index efdb2fa..d4b2275 100644
> > > --- a/target/ppc/cpu-models.h
> > > +++ b/target/ppc/cpu-models.h
> > > @@ -348,7 +348,8 @@ enum {
> > >      CPU_POWERPC_74x7A_v10          = 0x80030100, /* aka A: 1.0 */
> > >      CPU_POWERPC_74x7A_v11          = 0x80030101, /* aka B: 1.1 */
> > >      CPU_POWERPC_74x7A_v12          = 0x80030102, /* aka C: 1.2 */
> > > -    /* 64 bits PowerPC */
> > > +    CPU_POWERPC_74x7A_v15          = 0x80030105, /* aka D: 1.5 */
> > > +    /* 64 bits PowerPC */
> > >  #if defined(TARGET_PPC64)
> > >      CPU_POWERPC_620                = 0x00140000,
> > >      CPU_POWERPC_630                = 0x00400000,
> >
> > Hi James,
> >
> > You can find more information about submitting patches on the wiki at 
> > https://wiki.qemu.org/Contribute/SubmitAPatch.
> >
> > The main things I can see are missing are:
> >
> > - A suitable commit message with a "target/ppc: " subject prefix
> > - A Signed-off-by tag at the end of your commit message
> > - CC to qemu-devel mailing list
> > - CC to the current PPC maintainer (David Gibson)
> >
> > The best way to submit the patch is to use "git format-patch" and "git 
> > send-email" which makes sure that the resulting diff is escaped correctly and won't 
> > accidentally introduced whitespace errors as can occur with a lot of email clients.

It's also recommended to run scripts/checkpatch.pl on the patch file after 
git format-patch but before git send-email to verify it matches the coding 
style and fix what it reports.

> Thanks Mark, seems my patch is incomplete, -cpu help doesn’t list the v1.5 and 
> you can’t select it as a cpu. Tho, cpu host does work.
>
> I can’t seem to find the list that gets invoked when —cpu help is called?

Check cpu-models.c right next to the .h you've changed. By the way, are 
you sure the 7447_1.5 is also known as D? What about 1.3 and 1.4? Do those 
exist?

> Maybe I just need to run configure again, and make clean before I make?
>
> I made some changes, and just ran make again, and it just built the changes, 
> and linked a new qemu.

Running make clean after changing a .c or .h file should not be needed in 
most cases, make should rebuild what's needed.

Regards,
BALATON Zoltan