Re: [Qemu-ppc] [PATCH] ppc: Include vga cirrus card into the compiling process

[Thomas Huth]

On 19.06.2018 12:46, Sebastian Bauer wrote:
[...]
> In my opinion, it should be added to pci.mak (and removed from all
> present configs that include pci.mak). There is also CONFIG_VGA_PCI
> there, a bunch of network cards and other stuff. The Cirrus VGA is just
> another PCI card that one could plug into any systems that has a PCI(e)
> bus, also on physical hardware (whether it is supported by which guests
> is a different question).
> 
> However, I wanted to be conservative with my change so I added it only
> to the 32 bit PPC branch, because this is the platform that I can easily
> test. Does anybody know why CONFIG_VGA_CIRRUS is selectively enabled for
> PCI-based systems? What would speak against adding it to pci.mak?

I've got no real clue, but I think the Cirrus card is rather considered
as ugly legacy these days, e.g. see:

https://www.kraxel.org/blog/2014/10/qemu-using-cirrus-considered-harmful/

So I think it should not be added to boards that do not really need it.

 Thomas