[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH] etsec: fix IRQ (un)masking
From: |
David Gibson |
Subject: |
Re: [Qemu-ppc] [PATCH] etsec: fix IRQ (un)masking |
Date: |
Mon, 9 Jul 2018 16:25:09 +1000 |
User-agent: |
Mutt/1.10.0 (2018-05-17) |
On Mon, Jul 09, 2018 at 08:20:03AM +0200, Cédric Le Goater wrote:
11;rgb:ffff/ffff/ffff> On 11/28/2017 03:42 AM, Michael Davidsaver wrote:
> > Interrupt conditions occurring while masked are not being
> > signaled when later unmasked.
> > The fix is to raise/lower IRQs when IMASK is changed.
> >
> > To avoid problems like this in future, consolidate
> > IRQ pin update logic in one function.
>
> it makes sense.
>
> > Also fix probable typo "IEVENT_TXF | IEVENT_TXF",
> > and update IRQ pins on reset.
>
> Reviewed-by: Cédric Le Goater <address@hidden>
Thanks for the review Cédric. Unfortunately, I've mislaid the
original patch.
Michael, can you resend with Cédric's R-b included, please.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature