[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PATCH 06/10] r2d: Flash memory creation is
From: |
Peter Maydell |
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PATCH 06/10] r2d: Flash memory creation is confused about size, mark FIXME |
Date: |
Tue, 19 Feb 2019 16:21:56 +0000 |
On Tue, 19 Feb 2019 at 16:07, Philippe Mathieu-Daudé <address@hidden> wrote:
>
> On 2/18/19 1:56 PM, Markus Armbruster wrote:
> Good news: when you read (0x0000, 0x0000, 0x0000, 0x0000) pflash IDs,
> that means the code uses the "Virt PFlash". IOW this is not a physical
> model, since the guest obviously doesn't care about checking the flash
> model.
> The "VirtPFlash" only has 64KiB sectors.
>
> I suggest we add a pflash_cfi02_create_virt(reduced args) helper to make
> this obvious:
>
> pflash_cfi02_create_virt(paddr, name, size_bytes, mapping?).
What would this be, and when would you use it without a
/* FIXME this is not what the real hardware does */ ?
The real problem with most of these pflash creation calls
is that they're using bogus data for the flash device
(wrong IDs, wrong width, using the legacy weird implementation,
etc etc) because nobody cares much about the boards or has
real hardware to see what the hardware really is doing.
thanks
-- PMM
[Qemu-ppc] [PATCH 07/10] mips_malta: Clean up definition of flash memory size somewhat, Markus Armbruster, 2019/02/18
Re: [Qemu-ppc] [PATCH 07/10] mips_malta: Clean up definition of flash memory size somewhat, Alex Bennée, 2019/02/21
[Qemu-ppc] [PATCH 04/10] sam460ex: Don't size flash memory to match backing image, Markus Armbruster, 2019/02/18