Re: [Qemu-ppc] [Qemu-devel] [PATCH] Allow -sandbox off with --disable-seccomp

[Stefano Garzarella]

On Wed, Feb 27, 2019 at 12:21:32PM +1100, David Gibson wrote:
> At present, when seccomp support is compiled out with --disable-seccomp
> we fail with an error if the user puts -sandbox on the command line.
> 
> That kind of makes sense, but it's a bit strange that we reject a request
> to disable sandboxing with "-sandbox off" saying we don't support
> sandboxing.
> 
> This puts in a small sandbox to (correctly) silently ignore -sandbox off
> when we don't have sandboxing support compiled in.  This makes life easier
> for testcases, since they can safely specify "-sandbox off" without having
> to care if the qemu they're using is compiled with sandbox support or not.
> 
> Signed-off-by: David Gibson <address@hidden>
> ---
>  vl.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)

Reviewed-by: Stefano Garzarella <address@hidden>