qemu-riscv
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-riscv] [Qemu-devel] [PATCH] Clean up includes


From: Eric Blake
Subject: Re: [Qemu-riscv] [Qemu-devel] [PATCH] Clean up includes
Date: Tue, 4 Dec 2018 11:46:01 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1

On 12/4/18 11:25 AM, Markus Armbruster wrote:
Clean up includes so that osdep.h is included first and headers
which it implies are not included manually.

This commit was created with scripts/clean-includes, with the changes
to the following files manually reverted:

     contrib/libvhost-user/libvhost-user-glib.h
     contrib/libvhost-user/libvhost-user.c
     contrib/libvhost-user/libvhost-user.h

The script should probably auto-exclude contrib/ if none of those files make it into our final binary, and especially if they are meant to be compiled as stand-alone examples.

     linux-user/mips64/cpu_loop.c
     linux-user/mips64/signal.c
     linux-user/sparc64/cpu_loop.c
     linux-user/sparc64/signal.c
     linux-user/x86_64/cpu_loop.c
     linux-user/x86_64/signal.c
     target/s390x/gen-features.c
     tests/migration/s390x/a-b-bios.c
     tests/test-rcu-simpleq.c
     tests/test-rcu-tailq.c

Should any of these files be renamed *.c.inc to match their usage? (Presuming that you excluded them because they are pulled in via another .c file?)


Signed-off-by: Markus Armbruster <address@hidden>
---
  contrib/elf2dmp/pdb.h                     | 2 --
  contrib/elf2dmp/pe.h                      | 1 -
  contrib/elf2dmp/qemu_elf.h                | 1 -
  contrib/vhost-user-blk/vhost-user-blk.c   | 1 -
  contrib/vhost-user-scsi/vhost-user-scsi.c | 1 -

Hmm - my earlier question about auto-excluding contrib/ gets trickier. What's the rationale for including some files in here?

  hw/rdma/rdma_utils.c                      | 1 +
  hw/rdma/rdma_utils.h                      | 1 -
  hw/rdma/vmw/pvrdma_dev_ring.h             | 1 -
  hw/vfio/ap.c                              | 2 +-
  include/qemu/vfio-helpers.h               | 1 -
  include/sysemu/whpx.h                     | 1 -
  target/i386/sev.c                         | 3 ++-
  target/i386/whp-dispatch.h                | 1 -
  target/riscv/fpu_helper.c                 | 1 -
  tests/fp/platform.h                       | 1 -
  tests/tpm-util.h                          | 1 -
  tests/vhost-user-bridge.c                 | 2 +-
  util/qemu-thread-common.h                 | 1 -
  18 files changed, 5 insertions(+), 18 deletions(-)

The remainder of these files look reasonable.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org



reply via email to

[Prev in Thread] Current Thread [Next in Thread]