[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[qemu-s390x] [PATCH v2 0/5] Interactive Boot Menu for DASD and SCSI Gues

From: Collin L. Walling
Subject: [qemu-s390x] [PATCH v2 0/5] Interactive Boot Menu for DASD and SCSI Guests on s390x
Date: Mon, 11 Dec 2017 17:19:15 -0500

Thanks for your patience. I've been bouncing back-and-forth between different

Lots-o-changes this version.  Please call me out if I missed anything from the 
previous round of review.

--- [v2] ---


    - fixed up atoi and itostr and moved them to the new lib.c file

    - documentation follows gtk-doc (let me know if I'm missing something)

ipl structs

    - fixed up commit message

    - s/BootEckd*/Eckd*

boot option parsing

    - hw/s390x/ipl.c now handles *all* logic behind parsing command line values 
       and setting the appropriate values in the iplb (including interpreting 

    - pc-bios/s390-ccw/main.c now only sets the boot menu fields that were read 
       from the iplb (no longer interpreting loadparm here)

    - timeout value is now stored as seconds instead of milliseconds 
       (maximum of 65535 seconds [~18 hours])

    - error reported for invalid splash-time value
        - if splash-time is invalid, then set it to 0 (wait forever)
        - if splash-time is greater than max, then set it to max

    - s/boot_menu_enabled/boot_menu_flags

    - boot_menu_flags is set to *one* of these flags:
            - set if -boot menu=on or -machine loadparm=prompt
            - set if no boot options or loadparm are set

    - fixed ordering of the new fields in the iplb's

boot menu for eckd dasd

    - now supports zipl loader values

    - function chs removed and now using pre-existing function eckd_block_num 

    - sclp_read functionality and its helpers are now in menu.c, which is where 
       the only call to this function occurs
        - renamed to read_prompt
        - renamed read in sclp.c to sclp_read

    - introduced header menu.h

    - introduced new struct, ZiplParms that contains the following fields
       relating to zipl boot menu data:
        - flags
        - timeout
        - menu_start

    - stage2 reading cleaned up

    - no longer panic if boot menu data is not found -- instead just print a 
       message and boot default (what if the user did not configure a menu?)

boot menu for scsi

    - will only show a menu if BOOT_MENU_FLAG_BOOT_OPTS was set

--- [Summary] ---

These patches implement a boot menu for ECKD DASD and SCSI guests on s390x. 
The menu will only appear if the disk has been configured for IPL with the 
zIPL tool and with the following QEMU command line options:

    -boot menu=on[,splash-time=X] and/or -machine loadparm='prompt'

or via the following libvirt domain xml:

      <bootmenu enable='yes' timeout='X'/>

      <boot order='1' loadparm='PROMPT'/>

Where X is some positive integer representing time in milliseconds.

A loadparm other than 'prompt' will disable the menu and just boot 
the specified entry.

If no boot options are specified, we will attempt to use the values
provided by zipl (ECKD DASD only).

Collin L. Walling (5):
  s390-ccw: update libc
  s390-ccw: ipl structs for eckd cdl/ldl
  s390-ccw: parse and set boot menu options
  s390-ccw: interactive boot menu for eckd dasd
  s390-ccw: interactive boot menu for scsi

 hw/s390x/ipl.c              |  55 ++++++++++
 hw/s390x/ipl.h              |   8 +-
 pc-bios/s390-ccw/Makefile   |   2 +-
 pc-bios/s390-ccw/bootmap.c  | 104 +++++++++++++++----
 pc-bios/s390-ccw/bootmap.h  |  73 ++++++++------
 pc-bios/s390-ccw/iplb.h     |   8 +-
 pc-bios/s390-ccw/libc.c     |  75 ++++++++++++++
 pc-bios/s390-ccw/libc.h     |  31 ++++++
 pc-bios/s390-ccw/main.c     |  22 ++--
 pc-bios/s390-ccw/menu.c     | 237 ++++++++++++++++++++++++++++++++++++++++++++
 pc-bios/s390-ccw/menu.h     |  29 ++++++
 pc-bios/s390-ccw/s390-ccw.h |   2 +
 pc-bios/s390-ccw/sclp.c     |  30 ++++--
 pc-bios/s390-ccw/virtio.c   |   2 +-
 14 files changed, 600 insertions(+), 78 deletions(-)
 create mode 100644 pc-bios/s390-ccw/libc.c
 create mode 100644 pc-bios/s390-ccw/menu.c
 create mode 100644 pc-bios/s390-ccw/menu.h


reply via email to

[Prev in Thread] Current Thread [Next in Thread]