[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [qemu-s390x] [Qemu-devel] [PATCH] s390x: Add missing QEMU_NORETURN a

From: Thomas Huth
Subject: Re: [qemu-s390x] [Qemu-devel] [PATCH] s390x: Add missing QEMU_NORETURN attribute (CID 1383842)
Date: Mon, 18 Dec 2017 09:11:03 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0

On 18.12.2017 09:05, David Hildenbrand wrote:
>>> Or we could suppress the s390x compiler warning by using a compiler
>>> pragma. But I don't like that alternative.
>> I think the best solution would be to call tcg_s390_program_interrupt()
>> directly from helper_divs64() instead of going through the
>> s390_program_interrupt() wrapper. helper_divs64() is for TCG only, so it
>> should be fine to directly use the tcg_s390_program_interrupt() function
>> there.
> If there is not a good reason, I'd prefer to have only one function for
> injecting program interrupts. (adding 3 return statements looks IMHO
> nicer).

Agreed, that also makes the source code a little bit easier to read (you
don't have to look up that tcg_s390_program_interrupt() is marked as
noreturn this way).


reply via email to

[Prev in Thread] Current Thread [Next in Thread]