qemu-s390x
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [qemu-s390x] [Qemu-devel] [PATCH v1] s390x/tcg: fix disabling/enabli


From: Cornelia Huck
Subject: Re: [qemu-s390x] [Qemu-devel] [PATCH v1] s390x/tcg: fix disabling/enabling DAT
Date: Tue, 13 Feb 2018 18:47:59 +0100

On Tue, 13 Feb 2018 08:31:21 -0800 (PST)
address@hidden wrote:

> Checking PATCH 1/1: s390x/tcg: fix disabling/enabling DAT...
> WARNING: line over 80 characters
> #32: FILE: target/s390x/cpu.h:320:
> +#define FLAG_MASK_PSW                (FLAG_MASK_PER | FLAG_MASK_DAT | 
> FLAG_MASK_PSTATE \

I'll ignore this...

> 
> ERROR: code indent should never use tabs
> #32: FILE: target/s390x/cpu.h:320:
> +#define FLAG_MASK_PSW^I^I(FLAG_MASK_PER | FLAG_MASK_DAT | FLAG_MASK_PSTATE \$

...and just get rid of the pre-existing tabs here while merging, no
need to resend.

> 
> total: 1 errors, 1 warnings, 51 lines checked
> 
> Your patch has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 
> === OUTPUT END ===
> 
> Test command exited with code: 1
> 
> 
> ---
> Email generated automatically by Patchew [http://patchew.org/].
> Please send your feedback to address@hidden



reply via email to

[Prev in Thread] Current Thread [Next in Thread]