qemu-s390x
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [qemu-s390x] [PATCHv4 3/4] qmp: add architecture specific cpu data f


From: Eric Blake
Subject: Re: [qemu-s390x] [PATCHv4 3/4] qmp: add architecture specific cpu data for query-cpus-fast
Date: Fri, 16 Feb 2018 08:05:12 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0

On 02/16/2018 06:04 AM, Viktor Mihajlovski wrote:
The s390 CPU state can be retrieved without interrupting the
VM execution. Extendend the CpuInfoFast union with architecture

s/Extendend/Extend/
(And I mentioned this on my last review - it's no fun when new revisions miss picking up fixes)

specific data and an implementation for s390.

Return data looks like this:
  [
    {"thread-id":64301,"props":{"core-id":0},
     "arch":"s390","cpu-state":"operating",
     "qom-path":"/machine/unattached/device[0]","cpu-index":0},
    {"thread-id":64302,"props":{"core-id":1},
     "arch":"s390","cpu-state":"operating",
     "qom-path":"/machine/unattached/device[1]","cpu-index":1}
]

Signed-off-by: Viktor Mihajlovski <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>
Acked-by: Eric Blake <address@hidden>
---
  cpus.c           | 10 ++++++++++
  qapi-schema.json | 25 ++++++++++++++++++-------
  2 files changed, 28 insertions(+), 7 deletions(-)


I've now gone through the entire patch, so you can upgrade my Acked-by into

Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org



reply via email to

[Prev in Thread] Current Thread [Next in Thread]