[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [PATCH v2 0/4] Small fixes for s390x QEMU boot menu
From: |
Janosch Frank |
Subject: |
Re: [qemu-s390x] [PATCH v2 0/4] Small fixes for s390x QEMU boot menu |
Date: |
Mon, 16 Apr 2018 10:43:32 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 14.04.2018 00:08, Collin Walling wrote:
> Change Log:
>
> v2
>
> - added r-b's
> - s/zipl_println/zipl_print_entry
> - prints entry and returns entry number
> - while loop now handles valid_entries
Series reviewed-by: Janosch Frank <address@hidden>
>
> These patches fix the following:
>
> - The QEMU zIPL boot menu does not allow accurate selection of
> non-sequential entries.
>
> - The QEMU zIPL boot menu does not have all the capabilities of the
> real zIPL menu (such as commandline args). We should print a different
> banner to reflect this.
>
> - The loadparm array in main.c can end up being not null terminated when
> converted to an integer via atoui.
>
> - A loadparm set to an empty string does not allow a boot menu.
>
>
> Collin Walling (4):
> pc-bios/s390-ccw: rename MAX_TABLE_ENTRIES to MAX_BOOT_ENTRIES
> pc-bios/s390-ccw: fix loadparm initialization and int conversion
> pc-bios/s390-ccw: fix non-sequential boot entries (eckd)
> pc-bios/s390-ccw: fix non-sequential boot entries (enum)
>
> hw/s390x/ipl.c | 2 ++
> pc-bios/s390-ccw/bootmap.c | 16 +++++++------
> pc-bios/s390-ccw/bootmap.h | 2 --
> pc-bios/s390-ccw/main.c | 14 +++++------
> pc-bios/s390-ccw/menu.c | 58
> +++++++++++++++++++++++++++++++--------------
> pc-bios/s390-ccw/s390-ccw.h | 4 +++-
> 6 files changed, 61 insertions(+), 35 deletions(-)
>
signature.asc
Description: OpenPGP digital signature