qemu-s390x
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[qemu-s390x] [PULL 07/28] target/microblaze: avoid integer overflow in n


From: Richard Henderson
Subject: [qemu-s390x] [PULL 07/28] target/microblaze: avoid integer overflow in next_page PC check
Date: Wed, 9 May 2018 10:54:37 -0700

From: "Emilio G. Cota" <address@hidden>

If the PC is in the last page of the address space, next_page_start
overflows to 0. Fix it.

Reviewed-by: Richard Henderson <address@hidden>
Cc: "Edgar E. Iglesias" <address@hidden>
Signed-off-by: Emilio G. Cota <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
 target/microblaze/translate.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c
index 100883e2cc..0872dc9ded 100644
--- a/target/microblaze/translate.c
+++ b/target/microblaze/translate.c
@@ -1635,7 +1635,7 @@ void gen_intermediate_code(CPUState *cs, struct 
TranslationBlock *tb)
     uint32_t pc_start;
     struct DisasContext ctx;
     struct DisasContext *dc = &ctx;
-    uint32_t next_page_start, org_flags;
+    uint32_t page_start, org_flags;
     target_ulong npc;
     int num_insns;
     int max_insns;
@@ -1661,7 +1661,7 @@ void gen_intermediate_code(CPUState *cs, struct 
TranslationBlock *tb)
         cpu_abort(cs, "Microblaze: unaligned PC=%x\n", pc_start);
     }
 
-    next_page_start = (pc_start & TARGET_PAGE_MASK) + TARGET_PAGE_SIZE;
+    page_start = pc_start & TARGET_PAGE_MASK;
     num_insns = 0;
     max_insns = tb_cflags(tb) & CF_COUNT_MASK;
     if (max_insns == 0) {
@@ -1747,7 +1747,7 @@ void gen_intermediate_code(CPUState *cs, struct 
TranslationBlock *tb)
     } while (!dc->is_jmp && !dc->cpustate_changed
              && !tcg_op_buf_full()
              && !singlestep
-             && (dc->pc < next_page_start)
+             && (dc->pc - page_start < TARGET_PAGE_SIZE)
              && num_insns < max_insns);
 
     npc = dc->pc;
-- 
2.17.0




reply via email to

[Prev in Thread] Current Thread [Next in Thread]