qemu-s390x
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [qemu-s390x] [Qemu-devel] [PATCH v2 0/4] pc-bios/s390-ccw: Allow net


From: no-reply
Subject: Re: [qemu-s390x] [Qemu-devel] [PATCH v2 0/4] pc-bios/s390-ccw: Allow network booting via pxelinux.cfg
Date: Thu, 7 Jun 2018 05:31:00 -0700 (PDT)

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v2 0/4] pc-bios/s390-ccw: Allow network booting 
via pxelinux.cfg

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
   5d328d7d2f..8e36d27c5a  master     -> master
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
 t [tag update]            patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
132ffa3587 pc-bios/s390-ccw/net: Try to load pxelinux.cfg file accoring to the 
UUID
b3b73613ba pc-bios/s390-ccw/net: Add support for pxelinux-style config files
699020402a pc-bios/s390-ccw/net: Update code for the latest changes in SLOF
5dd76a9c89 roms: Update SLOF submodule to current status

=== OUTPUT BEGIN ===
Checking PATCH 1/4: roms: Update SLOF submodule to current status...
Checking PATCH 2/4: pc-bios/s390-ccw/net: Update code for the latest changes in 
SLOF...
Checking PATCH 3/4: pc-bios/s390-ccw/net: Add support for pxelinux-style config 
files...
Checking PATCH 4/4: pc-bios/s390-ccw/net: Try to load pxelinux.cfg file 
accoring to the UUID...
ERROR: space prohibited before open square bracket '['
#57: FILE: pc-bios/s390-ccw/netmain.c:267:
+                 : [cc] "=d" (cc)

total: 1 errors, 0 warnings, 74 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden

reply via email to

[Prev in Thread] Current Thread [Next in Thread]