Re: [qemu-s390x] [Qemu-devel] [PATCH 0/7] Some improvements in z/Arch instructions support

[Cornelia Huck]

On Wed, 15 Aug 2018 11:25:26 -0700 (PDT)
address@hidden wrote:

> === OUTPUT BEGIN ===
> Checking PATCH 1/7: tests/tcg: add a simple s390x test...
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #13: 
> new file mode 100644

tests/tcg/s390x/ does not seem to have a MAINTAINERS entry yet (it did
not contain anything interesting before, anyway.) Probably should be
added to the s390x/tcg section, as for the other architectures.

> 
> total: 0 errors, 1 warnings, 10 lines checked
> 
> Your patch has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> Checking PATCH 2/7: target/s390x: add BAL and BALR instructions...
> Checking PATCH 3/7: target/s390x: fix CSST decoding and runtime alignment 
> check...
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #72: 
> new file mode 100644
> 
> ERROR: space prohibited before open square bracket '['
> #98: FILE: tests/tcg/s390x/csst.c:22:
> +        : [op1] "+m" (op1),
> 
> ERROR: space prohibited before open square bracket '['
> #102: FILE: tests/tcg/s390x/csst.c:26:
> +        : [flags] "K" (0x0301),

Checkpatch often seems to have a hard time dealing with inline
assemblies. Probably best to just ignore the errors.