[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [PATCH v8 0/6] s390x: vfio-ap: guest dedicated crypto a
From: |
David Hildenbrand |
Subject: |
Re: [qemu-s390x] [PATCH v8 0/6] s390x: vfio-ap: guest dedicated crypto adapters |
Date: |
Mon, 17 Sep 2018 10:45:19 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
Am 12.09.18 um 22:08 schrieb Tony Krowiak:
> From: Tony Krowiak <address@hidden>
>
> This patch series is the QEMU counterpart to the KVM/kernel support for
> guest dedicated crypto adapters. The KVM/kernel model is built on the
> VFIO mediated device framework and provides the infrastructure for
> granting exclusive guest access to crypto devices installed on the linux
> host. This patch series introduces a new QEMU command line option, QEMU
> object model and CPU model features to exploit the KVM/kernel model.
>
> See the detailed specifications for AP virtualization provided by this
> patch set in docs/vfio-ap.txt for a more complete discussion of the
> design introduced by this patch series.
Besides using KVM_S390_VM_CRYPTO_ENABLE_APIE instead of
KVM_S390_VM_CPU_FEAT_AP to detect AP availability, this looks good to me
from a CPU model POV.
>
> v7 => v8 Change log:
> ===================
> * Enable SIE interpretation AP instructions if the CPU model feature for
> AP instructions is turned on for the guest.
>
> v6 => v7 Change log;
> ===================
> * Changed email address for Signed-off-by
>
> v5 => v6 Change log:
> ===================
> * Added reset handling fo vfio-ap device
> * Added a bridge/bus to AP device object model - thanks to Halil Pasic
>
> v4 => v5 Change log:
> ===================
> * Added MAINTAINERS entries for VFIO AP
> * Added explanation for why we are only supporting zEC12 and newer CPU
> models.
> * Changed CPU model feature qci=on|off to apqci=on|off
> * Misc. minor changes
>
> v3 => v4 Change log:
> ===================
> * Made vfio-ap device unpluggable for now
> * Renamed command line CPU model feature for QCI: qci=on -> apqci=on
> * Removed call to KVM_S390_VM_CRYPTO_INTERPRET_AP ioctl - ioctl was
> removed from kernel and AP instruction interpretation is set from the
> VFIO device driver
> * Added check to ensure only one vfio-ap device can be configured per
> guest
> * Removed AP instruction interception handlers: AP instructions will be
> interpreted by default if AP facilities are installed to handle the case
> where feature ap=on and no vfio-ap device is configured for the guest.
>
> Tony Krowiak (6):
> linux-headers: linux header updates for AP support
> s390x/cpumodel: Set up CPU model for AP device support
> s390x/kvm: enable/disable AP instruction interpretation for guest
> s390x/ap: base Adjunct Processor (AP) object model
> s390x/vfio: ap: Introduce VFIO AP device
> s390: doc: detailed specifications for AP virtualization
>
> MAINTAINERS | 14 +
> default-configs/s390x-softmmu.mak | 1 +
> docs/vfio-ap.txt | 785
> +++++++++++++++++++++++++++++++++++++
> hw/s390x/Makefile.objs | 2 +
> hw/s390x/ap-bridge.c | 76 ++++
> hw/s390x/ap-device.c | 39 ++
> hw/s390x/s390-virtio-ccw.c | 4 +
> hw/vfio/Makefile.objs | 1 +
> hw/vfio/ap.c | 186 +++++++++
> include/hw/s390x/ap-bridge.h | 37 ++
> include/hw/s390x/ap-device.h | 38 ++
> include/hw/vfio/vfio-common.h | 1 +
> linux-headers/asm-s390/kvm.h | 3 +
> linux-headers/linux/vfio.h | 2 +
> target/s390x/cpu_features.c | 3 +
> target/s390x/cpu_features_def.h | 3 +
> target/s390x/cpu_models.c | 2 +
> target/s390x/gen-features.c | 3 +
> target/s390x/kvm.c | 17 +
> 19 files changed, 1217 insertions(+), 0 deletions(-)
> create mode 100644 docs/vfio-ap.txt
> create mode 100644 hw/s390x/ap-bridge.c
> create mode 100644 hw/s390x/ap-device.c
> create mode 100644 hw/vfio/ap.c
> create mode 100644 include/hw/s390x/ap-bridge.h
> create mode 100644 include/hw/s390x/ap-device.h
>
>
--
Thanks,
David / dhildenb
- Re: [qemu-s390x] [PATCH v8 4/6] s390x/ap: base Adjunct Processor (AP) object model, (continued)
- Re: [qemu-s390x] [PATCH v8 4/6] s390x/ap: base Adjunct Processor (AP) object model, Christian Borntraeger, 2018/09/13
- Re: [qemu-s390x] [PATCH v8 4/6] s390x/ap: base Adjunct Processor (AP) object model, Tony Krowiak, 2018/09/13
- Re: [qemu-s390x] [PATCH v8 4/6] s390x/ap: base Adjunct Processor (AP) object model, Tony Krowiak, 2018/09/13
- Re: [qemu-s390x] [Qemu-devel] [PATCH v8 4/6] s390x/ap: base Adjunct Processor (AP) object model, Halil Pasic, 2018/09/13
- Re: [qemu-s390x] [Qemu-devel] [PATCH v8 4/6] s390x/ap: base Adjunct Processor (AP) object model, Tony Krowiak, 2018/09/14
[qemu-s390x] [PATCH v8 5/6] s390x/vfio: ap: Introduce VFIO AP device, Tony Krowiak, 2018/09/12
[qemu-s390x] [PATCH v8 6/6] s390: doc: detailed specifications for AP virtualization, Tony Krowiak, 2018/09/12
Re: [qemu-s390x] [PATCH v8 0/6] s390x: vfio-ap: guest dedicated crypto adapters,
David Hildenbrand <=
Re: [qemu-s390x] [PATCH v8 0/6] s390x: vfio-ap: guest dedicated crypto adapters, Cornelia Huck, 2018/09/20