Re: [qemu-s390x] [PATCH v9 0/6] s390x: vfio-ap: guest dedicated crypto adapters

[Cornelia Huck]

On Wed, 26 Sep 2018 18:54:34 -0400
Tony Krowiak <address@hidden> wrote:

> From: Tony Krowiak <address@hidden>
> 
> This patch series is the QEMU counterpart to the KVM/kernel support for 
> guest dedicated crypto adapters. The KVM/kernel model is built on the 
> VFIO mediated device framework and provides the infrastructure for 
> granting exclusive guest access to crypto devices installed on the linux 
> host. This patch series introduces a new QEMU command line option, QEMU 
> object model and CPU model features to exploit the KVM/kernel model.
> 
> See the detailed specifications for AP virtualization provided by this 
> patch set in docs/vfio-ap.txt for a more complete discussion of the 
> design introduced by this patch series.

This seems to look sane in general. However, before I merge this:

- This needs to wait for a proper headers sync, which can only be done
  after the Linux code hits upstream. Shouldn't be long, I guess (I can
  queue on a staging branch while waiting.)
- As I don't have the hardware, I cannot run more than some generic
  "verify it does not break anything" testing. So, I'd like to see a
  Tested-by by someone who actually does have access to the hardware.
- I'd like to see some more review/acks from others. If other (minor)
  things crop up, I'd prefer a respin (I don't want to juggle too many
  "minor changes"...)