[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-stable] [PATCH v2 03/10] xhci: Fix reset of MSI function
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-stable] [PATCH v2 03/10] xhci: Fix reset of MSI function |
Date: |
Fri, 11 May 2012 10:07:36 -0300 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2012-05-11 05:16, Gerd Hoffmann wrote:
> On 05/10/12 22:08, Jan Kiszka wrote:
>> Call msi_reset on device reset as still required by the core.
>
> Note: msi on xhci is disabled by default (and also broken as far I know).
OK, then we can likely skip this patch for 1.1/stable.
>
>> +static void xhci_reset(void *opaque)
>> +{
>> + XHCIState *xhci = opaque;
>> +
>
> if (xhci->msi)
Oops.
>
>> + msi_reset(&xhci->pci_dev);
>
> }
>
>> + xhci_reset_full(xhci);
>> +}
>
> And can't we let the pci core handle it so we don't need ugly wrappers
> like this?
That's what patches later in the series do. But Michael was preferring
this approach for 1.1 and the cleanup for 1.2.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux