[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-stable] [PULL 1/1] KVM: Use return value for error print
From: |
Michael Roth |
Subject: |
Re: [Qemu-stable] [PULL 1/1] KVM: Use return value for error print |
Date: |
Thu, 27 Feb 2014 09:52:31 -0600 |
User-agent: |
alot/0.3.4 |
Quoting Paolo Bonzini (2014-02-25 04:44:56)
> From: Alexander Graf <address@hidden>
>
> Commit 94ccff13 introduced a more verbose failure message and retry
> operations on KVM VM creation. However, it ended up using a variable
> for its failure message that hasn't been initialized yet.
>
> Fix it to use the value it meant to set.
>
> Cc: address@hidden
> Signed-off-by: Alexander Graf <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
Ping: last call for 1.7.1 (freeze today)
> ---
> kvm-all.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kvm-all.c b/kvm-all.c
> index f742f8d..979a8d9 100644
> --- a/kvm-all.c
> +++ b/kvm-all.c
> @@ -1427,7 +1427,7 @@ int kvm_init(void)
> } while (ret == -EINTR);
>
> if (ret < 0) {
> - fprintf(stderr, "ioctl(KVM_CREATE_VM) failed: %d %s\n", -s->vmfd,
> + fprintf(stderr, "ioctl(KVM_CREATE_VM) failed: %d %s\n", -ret,
> strerror(-ret));
>
> #ifdef TARGET_S390X
> --
> 1.7.1