[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-stable] [PATCH v5 0/4] Refactor device_set_realized to avoid r
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-stable] [PATCH v5 0/4] Refactor device_set_realized to avoid resource leak. |
Date: |
Tue, 2 Sep 2014 18:19:58 +0300 |
On Tue, Sep 02, 2014 at 08:03:04PM +0800, address@hidden wrote:
> From: Gonglei <address@hidden>
>
> after committing
> [PATCH v6 0/9] Refactor PCI/SHPC/PCIE hotplug to use a more generic hotplug
> API
Patches 1-3 make sense for qemu-stable?
Andreas could you please comment and if yes pick them
up and add Cc qemu-stable?
2.1.1 freeze is tomorrow.
> If devcie hotplugging failed, will casuse resource leak.
> This patch series include address resouce leak and two other issuses.
>
> v5 -> v4:
> - add patch 1/4 'Reviewed-by' tag.
> - change patch 2/4, propagate firsh child unrealizing failure, and
> change this patch's commit message.(Peter)
>
> v4 -> v3:
> - add patch 2/4.(Thanks for Peter's suggestion)
> - rework patch 3/4 based on patch 2/4.
>
> v3 -> v2:
> - add cleanup logic for set bus/child_bus realized/unrealized failed.
> - change patch 1/3 commit message, add 'Reviewed-by' tag.
>
> v2 -> v1:
> - rewrite patch 1/3, using error_abort instead of local_err.
> - rewrite patch 2/3, add cleanup logic for different error embranchment.
> - rewrite title of patch 3/3, and a syntax fix.
>
> Gonglei (4):
> qdev: using error_abort instead of using local_err
> qdev: using NULL instead of local_err for qbus_child unrealize
> qdev: add cleanup logic in device_set_realized() to avoid resource
> leak
> pcie: don't assert when hotplug a PCIe device with 'function != 0'
>
> hw/core/qdev.c | 69
> +++++++++++++++++++++++++++++++++++++++++++---------------
> hw/pci/pcie.c | 6 ++++-
> 2 files changed, 56 insertions(+), 19 deletions(-)
>
> --
> 1.7.12.4
>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-stable] [PATCH v5 0/4] Refactor device_set_realized to avoid resource leak.,
Michael S. Tsirkin <=