qemu-stable
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-stable] [PATCH v2 2/3] qapi: fix crash when a parameter is mis


From: Eric Blake
Subject: Re: [Qemu-stable] [PATCH v2 2/3] qapi: fix crash when a parameter is missing
Date: Thu, 22 Sep 2016 08:59:38 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0

On 09/22/2016 08:09 AM, Marc-André Lureau wrote:
> Calling:
> 
> { "execute": "qom-set",
>   "arguments": { "path": "/machine", "property": "rtc-time" } }
> 
> Will crash with:
> 
> qapi/qapi-visit-core.c:277: visit_type_any: Assertion `!err != !*obj'
> failed
> 
> Clear the obj and return an error.
> 
> The patch also fixes a similar potential crash in qmp_input_type_null()
> by checking qmp_input_get_object() returned a valid qobj.
> 
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
>  qapi/qmp-input-visitor.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]