qemu-stable
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-stable] [PATCH] migration: disable auto-converge during bulk b


From: Stefan Hajnoczi
Subject: Re: [Qemu-stable] [PATCH] migration: disable auto-converge during bulk block migration
Date: Fri, 22 Sep 2017 11:22:51 +0100
User-agent: Mutt/1.8.3 (2017-05-23)

On Thu, Sep 21, 2017 at 02:32:32PM +0200, Peter Lieven wrote:
> auto-converge and block migration currently do not play well together.
> During block migration the auto-converge logic detects that ram
> migration makes no progress and thus throttles down the vm until
> it nearly stalls completely. Avoid this by disabling the throttling
> logic during the bulk phase of the block migration.

Please include the rationale in a comment here:

> -        if (migrate_auto_converge()) {
> +        if (migrate_auto_converge() && !blk_mig_bulk_active()) {

That way it's clear why auto-converge isn't enabled when block migration
is active.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]