Re: [Qemu-stable] [Qemu-devel] [PATCH] mux: fix ctrl-a b again

[Philippe Mathieu-Daudé]

Hi,

>>> On 16 April 2018 at 19:18, Marc-André Lureau
>>> <address@hidden> wrote:
>>>> Commit fb5e19d2e1472e96d72d5e4d89c20033f8ab345c originally fixed the
>>>> regression, but was inadvertently broken again in merge commit
>>>> 2d6752d38d8acda.
>>>>
>>>> Fixes:
>>>> https://bugs.launchpad.net/qemu/+bug/1654137
>>>>
>>>> Cc: address@hidden
>>>> Signed-off-by: Marc-André Lureau <address@hidden>
>>>> ---
>>>>  chardev/char-mux.c | 1 +
>>>>  1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/chardev/char-mux.c b/chardev/char-mux.c
>>>> index 1b925c8dec..6055e76293 100644
>>>> --- a/chardev/char-mux.c
>>>> +++ b/chardev/char-mux.c
>>>> @@ -304,6 +304,7 @@ void mux_set_focus(Chardev *chr, int focus)
>>>>      }
>>>>
>>>>      d->focus = focus;
>>>> +    chr->be = d->backends[focus];
>>>>      mux_chr_send_event(d, d->focus, CHR_EVENT_MUX_IN);
>>>>  }
>>>>
>>>> --
>>>> 2.17.0.rc1.36.gcedb63ea2f
>>>
>>> Opinions welcome on whether this is a regression fix worth
>>> putting into rc4.
>>
>> It is a regression, but a long standing one - we've been broken for quite
>> a while since 2.9.0 or even before.
>>
>> If we're doing an rc4 anyway I'd suggest including it, but not the end of
>> the world if it has to go in via -stable given how long we've been broken
>> for.
>>
> 
> Thanks for the clarification; I've applied this to master.

Since this commit, the console on the Malta board stay black...

Before:
$ qemu-system-mips -M malta -m 512 \
  -kernel vmlinux-3.2.0-4-4kc-malta -append 'root=/dev/sda1' \
  -nographic
[    0.000000] Initializing cgroup subsys cpuset
[    0.000000] Initializing cgroup subsys cpu
[    0.000000] Linux version 3.2.0-4-4kc-malta
(address@hidden) (gcc version 4.6.3 (Debian 4.6.3-14) )
#1 Debian 3.2.51-1
[    0.000000] Config serial console: console=ttyS0,38400n8r
[    0.000000] bootconsole [early0] enabled
...

After:
$ qemu-system-mips -M malta -m 512 \
  -kernel vmlinux-3.2.0-4-4kc-malta -append 'root=/dev/sda1' \
  -nographic
QEMU 2.11.92 monitor - type 'help' for more information
(qemu) QEMU 2.11.92 monitor - type 'help' for more information
(qemu) q

1b2503fcf7b5932c5a3779ca2ceb92bd403c4ee7 is the first bad commit
Author: Marc-André Lureau <address@hidden>
Date:   Mon Apr 16 20:18:44 2018 +0200

    mux: fix ctrl-a b again

    Commit fb5e19d2e1472e96d72d5e4d89c20033f8ab345c originally fixed the
    regression, but was inadvertently broken again in merge commit
    2d6752d38d8acda.

    Fixes:
    https://bugs.launchpad.net/qemu/+bug/1654137