[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-stable] [PATCH v2 15/27] target/arm: Fix fp_status_f16 tinines
From: |
Peter Maydell |
Subject: |
Re: [Qemu-stable] [PATCH v2 15/27] target/arm: Fix fp_status_f16 tininess before rounding |
Date: |
Mon, 14 May 2018 14:59:51 +0100 |
On 12 May 2018 at 01:42, Richard Henderson <address@hidden> wrote:
> From: Peter Maydell <address@hidden>
>
> In commit d81ce0ef2c4f105 we added an extra float_status field
> fp_status_fp16 for Arm, but forgot to initialize it correctly
> by setting it to float_tininess_before_rounding. This currently
> will only cause problems for the new V8_FP16 feature, since the
> float-to-float conversion code doesn't use it yet. The effect
> would be that we failed to set the Underflow IEEE exception flag
> in all the cases where we should.
>
> Add the missing initialization.
>
> Fixes: d81ce0ef2c4f105
> Cc: address@hidden
> Signed-off-by: Peter Maydell <address@hidden>
> Signed-off-by: Richard Henderson <address@hidden>
NB that there are reviewed-by: tags from you and Alex that need
to be added to this commit message.
Thanks for fixing up the subject line for me.
thanks
-- PMM