qemu-stable
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-stable] [PATCH for-2.12.1] target/ppc: set is_jmp on ppc_tr_breakp


From: Emilio G. Cota
Subject: [Qemu-stable] [PATCH for-2.12.1] target/ppc: set is_jmp on ppc_tr_breakpoint_check
Date: Wed, 4 Jul 2018 15:53:27 -0400
User-agent: Mutt/1.5.24 (2015-08-30)

Cc'ing qemu-stable since the patch below is now in master:
  2a8ceef ("target/ppc: set is_jmp on ppc_tr_breakpoint_check", 2018-07-03)

Please pick up the patch for QEMU 2.12.1 -- it fixes a regression
introduced in 2.12.0.

Thanks,

                Emilio

On Mon, Jul 02, 2018 at 18:02:07 -0400, Emilio G. Cota wrote:
> The use of GDB breakpoints was broken by b0c2d52 ("target/ppc: convert
> to TranslatorOps", 2018-02-16).
> 
> Fix it by setting is_jmp, so that we break from the translation loop
> as originally intended.
> 
> Tested-by: Mark Cave-Ayland <address@hidden>
> Reported-by: Mark Cave-Ayland <address@hidden>
> Signed-off-by: Emilio G. Cota <address@hidden>
> ---
> (I'll send this to qemu-stable (for 2.12) once it's on master.)
> ---
>  target/ppc/translate.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/target/ppc/translate.c b/target/ppc/translate.c
> index 3a215a1..99c2731 100644
> --- a/target/ppc/translate.c
> +++ b/target/ppc/translate.c
> @@ -7314,6 +7314,7 @@ static bool ppc_tr_breakpoint_check(DisasContextBase 
> *dcbase, CPUState *cs,
>      DisasContext *ctx = container_of(dcbase, DisasContext, base);
>  
>      gen_debug_exception(ctx);
> +    dcbase->is_jmp = DISAS_NORETURN;
>      /* The address covered by the breakpoint must be included in
>         [tb->pc, tb->pc + tb->size) in order to for it to be
>         properly cleared -- thus we increment the PC here so that
> -- 
> 2.7.4
> 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]