[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-stable] [PATCH for-3.0] qcow: fix a reference leak
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-stable] [PATCH for-3.0] qcow: fix a reference leak |
Date: |
Thu, 26 Jul 2018 11:33:26 +0200 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
Am 25.07.2018 um 20:07 hat KONRAD Frederic geschrieben:
> Since 42a3e1ab367cdf38cce093de24eb406b99a4ef96 qemu asserts when using the
> vvfat driver:
>
> git clone git://qemu.org/qemu.git
> cd qemu
> ./configure --target-list=ppc-softmmu --enable-debug
> make -j8
> mkdir foo
> touch foo/hello
> ./ppc-softmmu/qemu-system-ppc -M prep --nographic --monitor null \
> -hda fat:rw:./foo
>
> "Ctrl-C"
>
> qemu-system-ppc: block.c:3368: bdrv_close_all: Assertion \
> `((&all_bdrv_states)->tqh_first == ((void *)0))' failed.
>
> This is because we reference bs twice in qcow_co_create(..) one time in
> bdrv_open_blockdev_ref(..) and in blk_insert_bs(..) but we unref it only once
> in blk_unref which leads to the reference leak.
>
> Note that I didn't tested much QCOW after this change as I don't use it much.
>
> Signed-off-by: KONRAD Frederic <address@hidden>
Thanks, applied to the block branch.
Kevin