|
From: | Avi Kivity |
Subject: | Re: [Qemu-trivial] [Qemu-devel] [PATCH] Use SIGIO with caution |
Date: | Tue, 31 May 2011 17:11:18 +0300 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc15 Lightning/1.0b3pre Thunderbird/3.1.10 |
On 05/31/2011 04:47 PM, Anthony Liguori wrote:
On 05/29/2011 04:50 PM, Andreas Färber wrote:BeOS and Haiku don't define SIGIO. When undefined, it won't arrive and doesn't need to be blocked. Signed-off-by: Andreas Färber<address@hidden>Anything to do with signal masks is never a trivial patch BTW...But I actually think explicit handling of SIGIO is unneeded. I think this is a hold over from the pre-I/O thread days where we selectively set SIGIO on certain file descriptors to make sure that when an IO fd became readable, we received a signal to break out of the KVM emulation loop.Can the folks on CC confirm/deny? I can't see any use of SIGIO in the current source tree.
We have O_ASYNC in enable_sigio_timer(). That's only used with HPET host timers, which should be very rare.
To be on the safe side I think we should take in the patch, and drop SIGIO support completely only if we decide the hpet host timer is not worth supporting.
-- error compiling committee.c: too many arguments to function
[Prev in Thread] | Current Thread | [Next in Thread] |