[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PATCH] lm4549: Fix buffer overflow
From: |
Stefan Weil |
Subject: |
[Qemu-trivial] [PATCH] lm4549: Fix buffer overflow |
Date: |
Sat, 1 Sep 2012 12:43:41 +0200 |
Report from smatch:
lm4549.c:234 lm4549_write_samples(14) error:
buffer overflow 's->buffer' 1024 <= 1024
There must be enough space to add two entries starting with index
s->buffer_level, therefore the old check was wrong.
Signed-off-by: Stefan Weil <address@hidden>
---
hw/lm4549.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/lm4549.c b/hw/lm4549.c
index 80b3ec4..e0137d5 100644
--- a/hw/lm4549.c
+++ b/hw/lm4549.c
@@ -224,7 +224,7 @@ uint32_t lm4549_write_samples(lm4549_state *s, uint32_t
left, uint32_t right)
This model supports 16-bit playback.
*/
- if (s->buffer_level >= LM4549_BUFFER_SIZE) {
+ if (s->buffer_level > LM4549_BUFFER_SIZE - 2) {
DPRINTF("write_sample Buffer full\n");
return 0;
}
--
1.7.10
- [Qemu-trivial] [PATCH] lm4549: Fix buffer overflow,
Stefan Weil <=