[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] block: Don't forget to delete temporary file
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-trivial] [PATCH] block: Don't forget to delete temporary file |
Date: |
Wed, 05 Sep 2012 17:40:25 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0 |
Il 05/09/2012 15:26, address@hidden ha scritto:
> From: Dunrong Huang <address@hidden>
>
> The caller would not delete temporary file after failed get_tmp_filename().
>
> Signed-off-by: Dunrong Huang <address@hidden>
> ---
> block.c | 6 +++++-
> 1 个文件被修改,插入 5 行(+),删除 1 行(-)
>
> diff --git a/block.c b/block.c
> index 074987e..2bc9f75 100644
> --- a/block.c
> +++ b/block.c
> @@ -433,7 +433,11 @@ int get_tmp_filename(char *filename, int size)
> return -EOVERFLOW;
> }
> fd = mkstemp(filename);
> - if (fd < 0 || close(fd)) {
> + if (fd < 0) {
> + return -errno;
> + }
> + if (close(fd) != 0) {
> + unlink(filename);
> return -errno;
> }
> return 0;
>
Not necessary, mkstemp will not create a file if it returns an error.
Paolo
Re: [Qemu-trivial] [Qemu-devel] [PATCH] block: Don't forget to delete temporary file, Kevin Wolf, 2012/09/11