[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] net/socket: Fix compiler warning (regression
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-trivial] [PATCH] net/socket: Fix compiler warning (regression for MinGW) |
Date: |
Sun, 23 Sep 2012 07:37:50 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Sat, Sep 22, 2012 at 09:13:28PM +0200, Stefan Weil wrote:
> Commit 213fd5087e2e4e2da10ad266df0ba950cf7618bf removed a type cast
> which is needed for MinGW:
>
> net/socket.c:136: warning:
> pointer targets in passing argument 2 of ‘sendto’ differ in signedness
> /usr/lib/gcc/amd64-mingw32msvc/4.4.4/../../../../amd64-mingw32msvc/include/winsock2.h:1313:
> note:
> expected ‘const char *’ but argument is of type ‘const uint8_t *’
>
> Add a 'qemu_sendto' macro which provides that type cast where needed
> and use the new macro instead of 'sendto'.
>
> Signed-off-by: Stefan Weil <address@hidden>
> ---
>
> I hope the modifications are trivial enough to justify that I did not
> split this in two patches.
>
> Regards
>
> Stefan W.
>
> net/socket.c | 6 +++---
> qemu-common.h | 5 +++++
> 2 files changed, 8 insertions(+), 3 deletions(-)
Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan