[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] disas/libvixl/a64/instructions-a64.h: Remove
From: |
Peter Maydell |
Subject: |
Re: [Qemu-trivial] [PATCH] disas/libvixl/a64/instructions-a64.h: Remove useless varialbe to avoid building break with '-Werror' |
Date: |
Thu, 9 Oct 2014 15:34:23 +0100 |
On 9 October 2014 15:00, Chen Gang <address@hidden> wrote:
> The related variables are useless, need be removed, or can not pass
> microblaze building, after fix it, can build microblaze, successfully.
>
> The related configuration:
>
> ./configure --target-list="arm-softmmu,microblazeel-softmmu" --enable-fdt
> --disable-kvm
>
> The related compiling error:
I build this code with both these targets enabled without any
problems.
There is an odd compiler thing where if you have any *other*
compilation issues then these warnings will also be emitted,
but once you've fixed that other compiler error then these
warnings are no longer produced. Maybe you ran into that?
The reason I'm reluctant to make changes to these files is
that they're pulled in from a different upstream project
(libvixl) so we should only fix critical problems in them,
or it makes new versions harder to update to.
thanks
-- PMM
Re: [Qemu-trivial] [Qemu-devel] [PATCH] disas/libvixl/a64/instructions-a64.h: Remove useless varialbe to avoid building break with '-Werror', Eric Blake, 2014/10/09
Re: [Qemu-trivial] [PATCH] disas/libvixl/a64/instructions-a64.h: Remove useless varialbe to avoid building break with '-Werror', Peter Maydell, 2014/10/21
Re: [Qemu-trivial] [PATCH] disas/libvixl/a64/instructions-a64.h: Remove useless varialbe to avoid building break with '-Werror', Michael Tokarev, 2014/10/23