[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH v3] vl: fix resource leak with mo
From: |
Fam Zheng |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH v3] vl: fix resource leak with monitor_fdset_add_fd |
Date: |
Mon, 16 Mar 2015 14:14:02 +0800 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Sun, 03/15 10:16, Paolo Bonzini wrote:
> monitor_fdset_add_fd returns an AddfdInfo struct (used by the QMP
> command add_fd). Free it.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>
> ---
> v1->v2: line length [Fam], pass &error_abort [Shannon]
> v2->v3: use "!!" instead of "? true : false" [Markus]
> ---
> vl.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index eba5d4c..5985680 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -1011,6 +1011,7 @@ static int parse_add_fd(QemuOpts *opts, void *opaque)
> int fd, dupfd, flags;
> int64_t fdset_id;
> const char *fd_opaque = NULL;
> + AddfdInfo *fdinfo;
>
> fd = qemu_opt_get_number(opts, "fd", -1);
> fdset_id = qemu_opt_get_number(opts, "set", -1);
> @@ -1060,8 +1061,9 @@ static int parse_add_fd(QemuOpts *opts, void *opaque)
> }
>
> /* add the duplicate fd, and optionally the opaque string, to the fd set
> */
> - monitor_fdset_add_fd(dupfd, true, fdset_id, fd_opaque ? true : false,
> - fd_opaque, NULL);
> + fdinfo = monitor_fdset_add_fd(dupfd, true, fdset_id, !!fd_opaque,
> fd_opaque,
> + &error_abort);
> + g_free(fdinfo);
>
> return 0;
> }
> --
> 2.3.0
>
>