[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PULL 05/19] block/ssh: remove dead code
From: |
Michael Tokarev |
Subject: |
[Qemu-trivial] [PULL 05/19] block/ssh: remove dead code |
Date: |
Thu, 8 Oct 2015 19:52:14 +0300 |
From: Paolo Bonzini <address@hidden>
The "err" label cannot be reached with qp != NULL. Remove the free-ing
of qp and avoid future regressions by removing the initializer.
Signed-off-by: Paolo Bonzini <address@hidden>
ACKed-by: Richard W.M. Jones <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
---
block/ssh.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/block/ssh.c b/block/ssh.c
index 8d06739..d35b51f 100644
--- a/block/ssh.c
+++ b/block/ssh.c
@@ -193,7 +193,7 @@ sftp_error_report(BDRVSSHState *s, const char *fs, ...)
static int parse_uri(const char *filename, QDict *options, Error **errp)
{
URI *uri = NULL;
- QueryParams *qp = NULL;
+ QueryParams *qp;
int i;
uri = uri_parse(filename);
@@ -249,9 +249,6 @@ static int parse_uri(const char *filename, QDict *options,
Error **errp)
return 0;
err:
- if (qp) {
- query_params_free(qp);
- }
if (uri) {
uri_free(uri);
}
--
2.1.4
- [Qemu-trivial] [PULL 00/19] Trivial patches for 2015-10-08, Michael Tokarev, 2015/10/08
- [Qemu-trivial] [PULL 10/19] target-ppc: Remove unnecessary variable, Michael Tokarev, 2015/10/08
- [Qemu-trivial] [PULL 03/19] sdhci: Change debug prints to compile unconditionally, Michael Tokarev, 2015/10/08
- [Qemu-trivial] [PULL 12/19] qapi: add missing @, Michael Tokarev, 2015/10/08
- [Qemu-trivial] [PULL 09/19] target-microblaze: Remove unnecessary variable, Michael Tokarev, 2015/10/08
- [Qemu-trivial] [PULL 14/19] hw: char: Remove unnecessary variable, Michael Tokarev, 2015/10/08
- [Qemu-trivial] [PULL 13/19] hw: timer: Remove unnecessary variable, Michael Tokarev, 2015/10/08
- [Qemu-trivial] [PULL 05/19] block/ssh: remove dead code,
Michael Tokarev <=
- [Qemu-trivial] [PULL 07/19] pc: check for underflow in load_linux, Michael Tokarev, 2015/10/08
- [Qemu-trivial] [PULL 17/19] linux-user: Use g_new() & friends where that makes obvious sense, Michael Tokarev, 2015/10/08
- [Qemu-trivial] [PULL 02/19] sdhci: use PRIx64 for uint64_t type, Michael Tokarev, 2015/10/08
- [Qemu-trivial] [PULL 11/19] MAINTAINERS: Add NSIS file for W32, W64 hosts, Michael Tokarev, 2015/10/08
- Re: [Qemu-trivial] [Qemu-devel] [PULL 00/19] Trivial patches for 2015-10-08, Peter Maydell, 2015/10/09
- [Qemu-trivial] [PULL 01/19] Add .dir-locals.el file to configure emacs coding style, Michael Tokarev, 2015/10/09
- [Qemu-trivial] [PULL 16/19] rocker: Use g_new() & friends where that makes obvious sense, Michael Tokarev, 2015/10/09
- [Qemu-trivial] [PULL 04/19] imx_serial: Generate interrupt on tx empty if enabled, Michael Tokarev, 2015/10/09
- [Qemu-trivial] [PULL 08/19] s/cpu_get_real_ticks/cpu_get_host_ticks/, Michael Tokarev, 2015/10/09