qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH] qga: fix erroneous argument to s


From: Marc-André Lureau
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] qga: fix erroneous argument to strerror
Date: Wed, 04 Jan 2017 17:58:15 +0000



On Wed, Jan 4, 2017 at 3:54 PM Paolo Bonzini <address@hidden> wrote:
process_command returns a negative value in case of error.  Make this
clear in the "if" statement and fix the strerror argument to flip it
to positive.

Signed-off-by: Paolo Bonzini <address@hidden>


Reviewed-by: Marc-André Lureau <address@hidden>


---
 qga/main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/qga/main.c b/qga/main.c
index 6caf215..538e4ee 100644
--- a/qga/main.c
+++ b/qga/main.c
@@ -558,8 +558,8 @@ static void process_command(GAState *s, QDict *req)
     rsp = qmp_dispatch(QOBJECT(req));
     if (rsp) {
         ret = send_response(s, rsp);
-        if (ret) {
-            g_warning("error sending response: %s", strerror(ret));
+        if (ret < 0) {
+            g_warning("error sending response: %s", strerror(-ret));
         }
         qobject_decref(rsp);
     }
--
2.9.3


--
Marc-André Lureau

reply via email to

[Prev in Thread] Current Thread [Next in Thread]