[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] jazz_led: fix bad snprintf
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH] jazz_led: fix bad snprintf |
Date: |
Wed, 03 May 2017 15:33:41 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Paolo Bonzini <address@hidden> writes:
> On 03/05/2017 14:56, Markus Armbruster wrote:
>>> snprintf writes at most 2 bytes here including the terminating NUL, so
>>> the result is truncated".
>>
>> You're right; I forgot that snprintf() always adds a NUL. So this *is*
>> broken: we write NUL instead of the second digit. Mentioning this in
>> the commit message wouldn't hurt.
>
> Well, it does, see the quote. :)
Yes, snprintf() truncates, but that's *internal* to
jazz_led_text_update(). The *external* effect isn't quite truncation,
it's writing NUL to the console instead of the second digit. That's
truncation only if the console ignores NUL. It might; I don't know.
Anyway, no big deal.
Re: [Qemu-trivial] [PATCH] jazz_led: fix bad snprintf, Michael Tokarev, 2017/05/05
Re: [Qemu-trivial] [PATCH] jazz_led: fix bad snprintf, Michael Tokarev, 2017/05/05